fix(ngRepeat): allow extra whitespaces in (key,value) of ngRepeat #6833
Conversation
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
Travis is not really reliable. |
|
This looks legit. @IgorMinar thoughts? I think this is innocuous. |
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa to
fd2d6c0
Compare
jeffbcross
force-pushed
the
master
branch
2 times, most recently
from
cad9560 to
f294244
Compare
jeffbcross
force-pushed
the
master
branch
4 times, most recently
from
e8dc429 to
e83fab9
Compare
petebacondarwin
force-pushed
the
master
branch
from
4dd5a20 to
998c61c
Compare
|
Agree with @btford - we could land it. @SekibOmazic could you please re-base it on top of the current master, as it doesn't merge cleanly any more? |
|
Oh, actually, it looks like it was already solved in master via c9705b7, at least partially. |
|
@pkozlowski-opensource So should I still rebase it? |
|
CLAs look good, thanks! |
|
@SekibOmazic yes, please. The thing is that some of the changes from your patch landed already via c9705b7, but I don't think this commit has all your changes. |
Whitespaces allowed in (key,value) expression of ngRepeat. e.g. ( aaa , bbb ) will be accepted by parser closes angular#6827
SekibOmazic
force-pushed
the
issue-6827
branch
from
2e9dc5e to
20fd2b6
Compare
|
@pkozlowski-opensource It's there but Travis seems to be flaky. |
|
@SekibOmazic yeh, TravisCI + SauceLabs are giving us headaches those days. Don't worry about those. |
Request Type:
How to reproduce:
Component(s): ngRepeat
Impact: small
Complexity: small
This issue is related to:
Detailed Description:
Other Comments:
Whitespaces allowed in (key,value) expression of ngRepeat.
e.g. ( aaa , bbb ) will be accepted by parser
closes #6827