Webstorm IDE complains about Regex Range #7093
Conversation
In CLASS_DIRECTIVE_REGEXP and COMMENT_DIRECTIVE_REGEXP, putting the \- character at the end of the character patter speeds up many IDE parsers and alleviates some errors in certain IDE's. (WebStorm 8) Functionally absolutely equivalent. No test change needed.
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
malixsys
changed the title
| @@ -512,8 +512,8 @@ $CompileProvider.$inject = ['$provide', '$$sanitizeUriProvider']; | |||
| function $CompileProvider($provide, $$sanitizeUriProvider) { | |||
| var hasDirectives = {}, | |||
| Suffix = 'Directive', | |||
| COMMENT_DIRECTIVE_REGEXP = /^\s*directive\:\s*([\d\w\-_]+)\s+(.*)$/, | |||
| CLASS_DIRECTIVE_REGEXP = /(([\d\w\-_]+)(?:\:([^;]+))?;?)/; | |||
| COMMENT_DIRECTIVE_REGEXP = /^\s*directive\:\s*([\d\w_\-]+)\s+(.*)$/, | |||
There was a problem hiding this comment.
Just moved - right by 1 character
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
@malixsys - can you sign the CLA please? |
|
Done. :) On 9 May 2014 08:37, Pete Bacon Darwin notifications@github.com wrote:
Martin Alix |
|
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
|
Note: signed with github@malix.com On 9 May 2014 08:37, Pete Bacon Darwin notifications@github.com wrote:
Martin Alix |
Minor change puts \- at end of character pattern In CLASS_DIRECTIVE_REGEXP and COMMENT_DIRECTIVE_REGEXP, putting the \- character at the end of the character patter speeds up many IDE parsers and alleviates some errors in certain IDE's. (WebStorm 8) Functionally absolutely equivalent. No test change needed. Closes #7093
|
thanks |
Minor change puts \- at end of character pattern In CLASS_DIRECTIVE_REGEXP and COMMENT_DIRECTIVE_REGEXP, putting the \- character at the end of the character patter speeds up many IDE parsers and alleviates some errors in certain IDE's. (WebStorm 8) Functionally absolutely equivalent. No test change needed. Closes angular#7093 Conflicts: src/ng/compile.js
Request Type: bug
How to reproduce: Open angular.js in WebStorm 8, complains that character class may not be used inside character range
Component(s): $compile
Impact: small
Complexity: small
This issue is related to:
Detailed Description:
In CLASS_DIRECTIVE_REGEXP and COMMENT_DIRECTIVE_REGEXP, putting the - character at the end of the character patter speeds up many IDE parsers and alleviates some errors in certain IDE's. (WebStorm 8)
Functionally absolutely equivalent. No test change needed.
Other Comments: