Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

feat(input): use ValidityState for required state #7123

Closed
wants to merge 2 commits into from
Closed

feat(input): use ValidityState for required state #7123

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5af9454
feat(input): use ValidityState for required state
starr0stealer Apr 16, 2014
fe8a298
feat(input): use ValidityState for required state
starr0stealer Apr 16, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/ng/directive/input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2059,8 +2059,15 @@ var requiredDirective = function() {
if (!ctrl) return;
attr.required = true; // force truthy in case we are on non input element

var validity = elm.prop('validity');
if (!isObject(validity)) {
validity = {
valid: true
};
}

var validator = function(value) {
if (attr.required && ctrl.$isEmpty(value)) {
if (attr.required && (validity.valueMissing || ctrl.$isEmpty(value))) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless Ian Hixon agrees to alter the spec (and in turn, fixes get added to browsers), what we really need to check for here is !validity.badInput --- because if badInput is set, then we're really suffering from bad input and not a "real" value missing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd also need to change textInputType() to run call setViewValue even if the value remains the same, if there is a validity state

ctrl.$setValidity('required', false);
return;
} else {
Expand Down