Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngSanitize): update to exclude smart quotes #7307

Closed
wants to merge 1 commit into from

Conversation

stickel
Copy link
Contributor

@stickel stickel commented Apr 30, 2014

Request Type: bug

How to reproduce: Add a smart quote (single or double) at the end of a
url string and filter the string with linky. Example plunker:
http://plnkr.co/edit/CeB5x48U0D1eXq4yXkvk?p=preview

Component(s): ngSanitize

Impact: small

Complexity: small

This issue is related to:

Detailed Description:

When smart quotes are included in content filtered through linky, any
smart quote at the end of a URL string will be included in the link
text and the href.

Other Comments:

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#7307)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@stickel
Copy link
Contributor Author

stickel commented Apr 30, 2014

Using the issue template suggested.

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@stickel stickel added cla: no and removed cla: yes labels May 1, 2014
@stickel
Copy link
Contributor Author

stickel commented May 2, 2014

CLA signed.

@IgorMinar
Copy link
Contributor

cla verification failed likely due to email address mismatch, you check the email address you used to create the commit here: https://github.com/angular/angular.js/pull/7307.patch

@IgorMinar
Copy link
Contributor

it would also be good to remove the extra commits from this branch so that we are left with only one commit in the pr

@stickel stickel force-pushed the fix-ngsanitize-linky-filter branch from 5cd6104 to 1918f1b Compare October 12, 2014 19:12
Request Type: bug

How to reproduce: Add a smart quote (single or double) at the end of a
url string and filter the string with linky. Example plunker:
http://plnkr.co/edit/CeB5x48U0D1eXq4yXkvk?p=preview

Component(s): ngSanitize

Impact: small

Complexity: small

Detailed Description:

When smart quotes are included in content filtered through linky, any
smart quote at the end of a URL string will be included in the link
text and the href.
@stickel stickel force-pushed the fix-ngsanitize-linky-filter branch from 1918f1b to adf0754 Compare October 12, 2014 19:19
@stickel
Copy link
Contributor Author

stickel commented Oct 12, 2014

@IgorMinar Email address should be updated and extra commits have been removed.

@caitp
Copy link
Contributor

caitp commented Oct 16, 2014

(adding cla: maybe to remind me to check on it tomorrrow)

@caitp
Copy link
Contributor

caitp commented Oct 23, 2014

@stickel I'm sorry but the email from https://github.com/angular/angular.js/pull/7307.patch was not found to be signed.

If you've signed as a corporation, please let us know --- otherwise, please ensure that your commit is authored with the email you've signed with, thanks.

If you need help changing the commit email, try git commit --amend --author="name <email@address>" --- where the email follows the name between angle brackets.

@stickel
Copy link
Contributor Author

stickel commented Oct 23, 2014

@caitp Sorry about that. I've changed the commit with the command you gave. Hopefully it works this time.

@petebacondarwin petebacondarwin modified the milestones: 1.3.5, Backlog Nov 23, 2014
@petebacondarwin
Copy link
Contributor

Related to #9256

@petebacondarwin
Copy link
Contributor

Hi @stickel - can you just check that you have associated your github account name with the CLA you signed? See https://cla.developers.google.com/clas

@pkozlowski-opensource pkozlowski-opensource modified the milestones: 1.3.5, 1.3.6 Dec 1, 2014
@stickel
Copy link
Contributor Author

stickel commented Dec 1, 2014

Hey @petebacondarwin — My GitHub account name and personal email address have signed the CLA.

@googlebot
Copy link

CLAs look good, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants