-
Notifications
You must be signed in to change notification settings - Fork 27.4k
fix(ngSanitize): update to exclude smart quotes #7307
Conversation
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
Using the issue template suggested. |
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
CLA signed. |
02dc2aa
to
fd2d6c0
Compare
cad9560
to
f294244
Compare
e8dc429
to
e83fab9
Compare
cla verification failed likely due to email address mismatch, you check the email address you used to create the commit here: https://github.com/angular/angular.js/pull/7307.patch |
it would also be good to remove the extra commits from this branch so that we are left with only one commit in the pr |
5cd6104
to
1918f1b
Compare
Request Type: bug How to reproduce: Add a smart quote (single or double) at the end of a url string and filter the string with linky. Example plunker: http://plnkr.co/edit/CeB5x48U0D1eXq4yXkvk?p=preview Component(s): ngSanitize Impact: small Complexity: small Detailed Description: When smart quotes are included in content filtered through linky, any smart quote at the end of a URL string will be included in the link text and the href.
1918f1b
to
adf0754
Compare
@IgorMinar Email address should be updated and extra commits have been removed. |
(adding |
4dd5a20
to
998c61c
Compare
@stickel I'm sorry but the email from https://github.com/angular/angular.js/pull/7307.patch was not found to be signed. If you've signed as a corporation, please let us know --- otherwise, please ensure that your commit is authored with the email you've signed with, thanks. If you need help changing the commit email, try |
@caitp Sorry about that. I've changed the commit with the command you gave. Hopefully it works this time. |
Related to #9256 |
Hi @stickel - can you just check that you have associated your github account name with the CLA you signed? See https://cla.developers.google.com/clas |
Hey @petebacondarwin — My GitHub account name and personal email address have signed the CLA. |
CLAs look good, thanks! |
Request Type: bug
How to reproduce: Add a smart quote (single or double) at the end of a
url string and filter the string with linky. Example plunker:
http://plnkr.co/edit/CeB5x48U0D1eXq4yXkvk?p=preview
Component(s): ngSanitize
Impact: small
Complexity: small
This issue is related to:
Detailed Description:
When smart quotes are included in content filtered through linky, any
smart quote at the end of a URL string will be included in the link
text and the href.
Other Comments: