feat(input): add input type=range support #7370
Conversation
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
Bind model of <input type="range"> to number (like <input type="number">) rather than string. Range inputs represent numerical values; therefore, a numerical binding makes more sense than a string binding. Closes angular#1189, angular#5892
TylerEich
changed the title
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
|
It looks like there's only one change in this PR. I'm gonna close this for now, but feel free to open a new one. Thanks! |
|
Sorry, did you mean to merge this?
Yes, it's a super useful one-line change. Apologies if I'm missing something. (I just ran into the issue with |
|
Oh, I was confused by the other commits in the PR that have nothing to do with the issue. You need to clean up the pull request, and also add some tests to show that range behaves correctly. |
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa to
fd2d6c0
Compare
jeffbcross
force-pushed
the
master
branch
4 times, most recently
from
e8dc429 to
e83fab9
Compare
petebacondarwin
force-pushed
the
master
branch
from
4dd5a20 to
998c61c
Compare
the input[type=range] behavior is the same of an input[type=number] with min=0, max=100 and step=1 as defaults Closes angular#5892, angular#8241, angular#7370
the input[type=range] behavior is the same of an input[type=number] with min=0, max=100 and step=1 as defaults Closes angular#5892, angular#8241, angular#7370
|
Dupe of #9715 |
Request Type: feature
How to reproduce:
Component(s): misc core
Impact: small
Complexity: small
This issue is related to:
Detailed Description:
Bind model of to number (like ) rather than string. Range inputs represent numerical values; therefore, a numerical binding makes more sense than a string binding.
Other Comments:
Closes #5892, #1189