-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Conversation
Add a function to detect if is FirefoxOS system, then if it´s true it add the attribute mozSystem: true that is needed for firefox os apps to work.
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
Add a function to detect if is FirefoxOS system, then if it´s true it add the attribute mozSystem: true that is needed for firefox os apps to work.
this refers to issue #2318 |
We can't enable this by default, the option is in FirefoxOS for a reason (security). Instead we should make it possible to define an object who's properties should be copied to the XHR object, once created. |
so you could use it as if you'd like to implement this, please open a new PR. thanks! |
We already do this for a number of properties in the config object, it would be trivial to just make a whitelist of allowed properties to copy in if present, and a bit nicer than adding a new object property to the config, IMO. |
then we need to maintain the whitelist and people will want to add stuff into the list of every possible platform out there. another option is to whitelist our properties and copy everything else. |
What if it were just configurable via httpProvider, similar to sce whitelists? |
It´ll be nicer if we can make it configurable, because it´s a pattern in firefox os, to do a XHR you need to add this feature always, if we can use it as a config it´ll be a lot easier for the firefox os app developers. |
Or, to take a line from Ember/Rails playbooks, go with "convention over configuration" and supply a default set of properties for "mainstream" platforms, while still enabling people to work around them if they need to |
The definition of mainstream changes over time but removing special cases is then not trivial. So I'd rather avoid that as much as possible. The solution I proposed earlier would work with providers as well. In this case the config block would change the defaults exposed on the provider and set the property. |
Add a function to detect if is FirefoxOS system, then if it´s true it add the attribute mozSystem: true that is needed for firefox os apps to work.