Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix($rootScope): cleanup on $destroy also for $rootScope #7564

Closed
wants to merge 1 commit into from
Closed

fix($rootScope): cleanup on $destroy also for $rootScope #7564

wants to merge 1 commit into from

Conversation

shahata
Copy link
Contributor

@shahata shahata commented May 23, 2014

No description provided.

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#7564)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@shahata shahata added cla: yes and removed cla: no labels May 23, 2014
@rodyhaddad rodyhaddad added this to the Backlog milestone Jun 10, 2014
@IgorMinar
Copy link
Contributor

this is not sufficient because of all the global DOM listeners we registered, these would leak if not deregistered. A more complete solution is #8005.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants