Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Conversation

@rodyhaddad
Copy link
Contributor

@lgalfaso's PR #7543 had two aspects of it that I didn't include in my last changes to $parse (#7552, #7555)

  • Lexer should only take care of constant, and the Parser should deduce that a primary constant is also a literal
  • Simplify the logic of Parser.filter

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#7571)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

src/ng/parse.js Outdated

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The $log annotation is still present here, but the variable was removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops!
Fixed, thank you :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants