Update jqLite.js documentation for css() function. #7599
Conversation
The jQuery css() getter functionality utilises getComputedStyle() whereas jqLite only retrieves what is declared inline on an element.
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
Related: #2866 |
|
I'm fine on merging this for the time being, but do we want to implement the change in #2866? It's possibly breaking, but also doesn't seem like it adds many bytes. |
|
I'm definitely a fan of implementing the change in #2866 as this is what I was originally intending to do but got stung by this gotcha. I don't imagine anyone only intends to receive only inline styles |
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa to
fd2d6c0
Compare
|
Implementing a full getter will not be done as explained here: #8161 (comment) This can be mergred now. |
The jQuery css() getter functionality utilises getComputedStyle() whereas jqLite only retrieves what is declared inline on an element. Closes #7599
Request Type: docs
How to reproduce:
Component(s): jqLite
Impact: small
Complexity: small
This issue is related to: jqLite documentation
Detailed Description: The jQuery css() getter functionality utilises getComputedStyle() whereas jqLite only retrieves what is declared inline on an element.
Other Comments: