Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Add note about needing ng-app="myApp" in Step 5 #7655

Closed
wants to merge 1 commit into from

Conversation

chadoh
Copy link

@chadoh chadoh commented Jun 1, 2014

Request Type: docs

How to reproduce:

Component(s): misc core

Impact: small

Complexity: small

This issue is related to:

Detailed Description:

This document was how I learned about using the inline, anonymous controller definition. It took me a long time and much frustration to figure out that I needed to change ng-app in my markup in order for this to work. I'm hoping to save some time for the next person who takes the same path as me.

Other Comments:

This document was how I learned about using the inline, anonymous controller definition. It took me a long time and much frustration to figure out that I needed to change `ng-app` in my markup in order for this to work. I'm hoping to save some time for the next person who takes the same path as me.
@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#7655)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@chadoh
Copy link
Author

chadoh commented Jun 1, 2014

Hi, @mary-poppins. I've updated the description. Thanks!

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@chadoh chadoh added cla: no and removed cla: yes labels Jun 5, 2014
@chadoh
Copy link
Author

chadoh commented Jun 6, 2014

I've signed the CLA.

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@chadoh chadoh added cla: yes and removed cla: no labels Jun 6, 2014
@petebacondarwin
Copy link
Contributor

Actually this needs to come in step 2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants