Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update index.ngdoc #7665

Closed
wants to merge 1 commit into from
Closed

Update index.ngdoc #7665

wants to merge 1 commit into from

Conversation

gsc-leticia
Copy link
Contributor

nodejs-legacy extra package is needed in Debian, for compatibility.

In http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=614907#108 you will find this comments:

  1. The nodejs package shall be changed to provide /usr/bin/nodejs, not /usr/bin/node. The package should declare a Breaks: relationship with any packages in Debian that reference /usr/bin/node.
  2. The nodejs source package shall also provide a nodejs-legacy binary package at Priority: extra that contains /usr/bin/node as a symlink to /usr/bin/nodejs. No package in the archive may depend on or recommend the nodejs-legacy package, which is provided solely for upstream
    compatibility. This package declares shall also declare a Conflicts: relationship with the node package.

nodejs-legacy extra package is needed in Debian, for compatibility.

In http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=614907#108 you will find this comments:

1. The nodejs package shall be changed to provide /usr/bin/nodejs, not /usr/bin/node. The package should declare a Breaks: relationship with any packages in Debian that reference /usr/bin/node.

2. The nodejs source package shall also provide a nodejs-legacy binary package at Priority: extra that contains /usr/bin/node as a symlink to /usr/bin/nodejs. No package in the archive may depend on or recommend the nodejs-legacy package, which is provided solely for upstream
compatibility. This package declares shall also declare a Conflicts: relationship with the node package.
@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#7665)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@btford
Copy link
Contributor

btford commented Jun 3, 2014

Thanks for the PR!

I'm not sure how best to deal with caveats like this. On one hand, it's nice to remove any starting impediments. On the other, it means that as instructions for installing node change, we also have to update them here.

In the past, we've rejected additions to the docs like this.

@petebacondarwin I'm wondering if it would be better to add a link to a more definitive guide elsewhere for installing node on all platforms.

@petebacondarwin
Copy link
Contributor

So if I were installing node on Debian I would follow the link we give to http://nodejs.org/download/ and then see the installing from package managers link. Following that gives the necessary information about Debian.

But I also note that further up in this page we already give some specific information about using node on Debian. I.E. That since there is a name clash with node on Debian you should use nodejs. But since that instruction only works if node-legacy has been installed, we should probably just note that there. I doubt this is likely to change in the near-to-mid-future from reading the bug issue.

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@petebacondarwin
Copy link
Contributor

@gsc-leticia and @btford - is this change acceptable? #7723

@gsc-leticia
Copy link
Contributor Author

@petebacondarwin Yes, I think so. Thanks

@btford
Copy link
Contributor

btford commented Jun 6, 2014

👍 – make sure to credit @gsc-leticia in the commit message though.

petebacondarwin added a commit that referenced this pull request Jun 6, 2014
Thanks to GSC Leticia (gsc-leticia) for identifying this problem.

Closes #7665
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants