-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Conversation
callback function return parameter with iteration count
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
This has two problems with it.
Better solution, make a note about the callback function signature in the description of the parameter. |
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
Text describing the parameter changed. New version is based on the format from documentation of $watch.
You updated the docs in the ngMock version of $interval. What's surprising, is that this behavior isn't tested at all, so I wonder if we want it or not. |
Actually, I didn't look at the mock documentation, so maybe I'm wrong. But it looks like function parameters don't get serialized in any way in the function parameter docs |
Okay, it is getting rendered in this case, although it doesn't actually look very good. So that's better than nothing. Ignore criticism 2 and fix the jscs/jshint issues, we can merge this |
This is my first try of updating the documentation. |
02dc2aa
to
fd2d6c0
Compare
cad9560
to
f294244
Compare
abdaab7
to
30996f8
Compare
e8dc429
to
e83fab9
Compare
4dd5a20
to
998c61c
Compare
callback function return parameter with iteration count