Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

feat(ngRoute): alias string as redirectTo property in .otherwise() #7809

Closed
wants to merge 1 commit into from

Conversation

ealtenho
Copy link
Contributor

Allow .otherwise() to interpret a string parameter
as the redirectTo property to handle the common misinterpretation
that .otherwise() takes as a parameter the string to be matched
in the otherwise case.

Closes #7794

Allow .otherwise() to interpret a string parameter
as the redirectTo property to handle the common misinterpretation
that .otherwise() takes as a parameter the string to be matched
in the otherwise case.

Closes angular#7794
@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@ealtenho ealtenho added cla: no and removed cla: yes labels Jun 12, 2014
@btford btford added this to the 1.3.0 milestone Jun 12, 2014
@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@btford
Copy link
Contributor

btford commented Aug 28, 2014

Made a couple changes, landed as 3b5d75c.

@btford btford closed this Aug 28, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: warn when passing a string to $routeProvider.otherwise()
3 participants