Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update step_03.ngdoc #7815

Closed
wants to merge 1 commit into from
Closed

Update step_03.ngdoc #7815

wants to merge 1 commit into from

Conversation

ifalvarez
Copy link
Contributor

  1. The original document is not clear to a new developer in where to place the code.
  2. The query.clear() statement to clear the query before the second test is missing in the original document.
  3. Refactored to use the query and phoneList variables in both tests, so its easier to read and understand.

1) The original document is not clear to a new developer in where to place the code.
2) The query.clear() statement to clear the query before the second test is missing in the original document. 
3) Refactored to use the query and phoneList variables in both tests, so its easier to read and understand.
@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@IgorMinar
Copy link
Contributor

lgtm. thanks

IgorMinar pushed a commit that referenced this pull request Jul 25, 2014
1) The original document is not clear to a new developer in where to place the code.
2) The query.clear() statement to clear the query before the second test is missing in the original document.
3) Refactored to use the query and phoneList variables in both tests, so its easier to read and understand.

Closes #7815
@IgorMinar IgorMinar closed this in 46f755a Jul 25, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants