Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

perf($compile): remove no longer need nodeType filter when setting $scope data #7887

Closed
wants to merge 1 commit into from
Closed

perf($compile): remove no longer need nodeType filter when setting $scope data #7887

wants to merge 1 commit into from
+1 −8

Conversation

jbedard
Copy link
Contributor

@jbedard jbedard commented Jun 18, 2014

Now that a196c8b added the nodeType check it doesn't have to be done by the link function. This avoids the .eq() call which created a new jQuery/jqLite object for each element.

@jbedard
perf($compile): no longer need nodeType filter when setting $scope data

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
200b6b5
@jbedard jbedard added cla: yes and removed cla: no labels Jun 18, 2014
@rodyhaddad rodyhaddad added this to the 1.3.0-beta.14 milestone Jun 18, 2014
@rodyhaddad
Copy link
Contributor

LGTM

@rodyhaddad rodyhaddad self-assigned this Jun 30, 2014
@rodyhaddad rodyhaddad closed this in b0ca519 Jul 1, 2014
@rodyhaddad
Copy link
Contributor

Thanks! :-)

ckknight pushed a commit to ckknight/angular.js that referenced this pull request Jul 16, 2014
@jbedard
perf($compile): no longer need nodeType filter when setting $scope data

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
f0af25b 
Closes angular#7887
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rodyhaddad rodyhaddad

Labels
cla: yes component: $compile frequency: high needs: merging type: perf
Projects
None yet
Milestone
1.3.0-beta.15
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbedard @rodyhaddad @caguillen214