Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix($animate): remove the ng-animate className after canceling animation #7948

Closed
wants to merge 1 commit into from

Conversation

matsko
Copy link
Contributor

@matsko matsko commented Jun 23, 2014

Closes #7784
Closes #7801
Closes #7894

@matsko matsko added cla: yes and removed cla: no labels Jun 23, 2014
@rodyhaddad rodyhaddad added this to the 1.3.0 milestone Jun 23, 2014
@@ -690,6 +690,46 @@ describe("ngAnimate", function() {
expect(child.hasClass('animation-cancelled')).toBe(true);
}));

it("should remove the .ng-animate className after a former animation was cancelled and then after the follow-up class-based animation has completed", function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that is a long it clause description! We should wrap it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe we should just shorten/simplify it? I think the long-form details of this description should be written as comments throughout the test, because I gotta tell you it's pretty hard to follow what's going on there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a bit tricky to phrase:

should remove the .ng-animate class after the next animation is run which interrupted the last animation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for better docs for the test

@matsko
Copy link
Contributor Author

matsko commented Jul 1, 2014

MERGED.

Landed as e18db78

@matsko matsko closed this Jul 1, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng-animate class stuck on element when using ng-route ng-animate class not removed if removeClass() called before addClass() completes
6 participants