This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($animate): remove the ng-animate className after canceling animation #7948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -690,6 +690,46 @@ describe("ngAnimate", function() { | |||
| expect(child.hasClass('animation-cancelled')).toBe(true); | |||
| })); | |||
|
|
|||
| it("should remove the .ng-animate className after a former animation was cancelled and then after the follow-up class-based animation has completed", function() { | |||
There was a problem hiding this comment.
Now that is a long it clause description! We should wrap it.
There was a problem hiding this comment.
or maybe we should just shorten/simplify it? I think the long-form details of this description should be written as comments throughout the test, because I gotta tell you it's pretty hard to follow what's going on there.
There was a problem hiding this comment.
it's a bit tricky to phrase:
should remove the .ng-animate class after the next animation is run which interrupted the last animation
There was a problem hiding this comment.
+1 for better docs for the test
|
MERGED. Landed as e18db78 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7784
Closes #7801
Closes #7894