fix(numberFilter): correctly round fractions despite floating-point arithmetics issues in JS

[IgorMinar]

Closes #7870
Closes #7878

[mary-poppins]

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

• Uses the issue template (#7962)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

[lgalfaso]

LGTM

[lgalfaso]

Looks I spoke too soon as it looks like there are some issues with IE10 and NaN

[caitp]

All of them, not just IE

[IgorMinar]

I fixed that and pushed a new version. waiting for travis..

[lgalfaso]

@caitp you are right

[anton000]

was about to submit a pull request. fix was:
var fraction = ('' + number.toFixed(fractionSize+1)).split(DECIMAL_SEP);

[IgorMinar]

toFixed has the same issues with floating point arithmetics as regular
operators:

(1.255).toFixed(2)
=> 1.25

On Thu, Jun 26, 2014 at 6:44 AM, Anthony Chua notifications@github.com
wrote:

was about to submit a pull request. fix was:
var fraction = ('' + number.toFixed(fractionSize+1)).split(DECIMAL_SEP);

—
Reply to this email directly or view it on GitHub
#7962 (comment).

[anton000]

yup. i meant using the old code:

var pow = Math.pow(10, fractionSize + 1);
number = Math.floor(number * pow + 5) / pow;
var fraction = (' ' + number.toFixed(fractionSize+1)).split(DECIMAL_SEP);

fixed the problem of getting notation format on 0 with a fractionSize > 5