This repository was archived by the owner on Apr 12, 2024. It is now read-only.
perf($compile, jqLite): reduce creation of unnecessary jquery objects #7963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
- updated the internal jqLite helpers to use the low-level jqLite.data/removeData to avoid unnecessary jq wrappers and loops - updated $compile to use the low-level jqLite.data/removeData to avoid unnecessary jq wrappers at link time
…educe-jquery-objects Conflicts: test/jqLiteSpec.js
|
LGTM |
|
this is good stuff. I reviewed the commits and they all look good to me. |
|
@rodyhaddad can you get this in and backport to 1.2.x please? |
Closed
|
Awesome, thanks for squashing those and getting them in! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the creation of many duplicate or unnecessary jQuery objects in the compile/link phases as well as in some jqLite methods.
Most of the changes are pretty minor and safe (as far as myself and the tests can tell).
The only bigger change is exposing
jqLiteData/jqLiteRemoveDataasjqLite.data/removeDatato match the jQuery equivalent (https://api.jquery.com/jquery.data/). This allows getting/setting data without creating the jQuery wrapper object and allows for the biggest reduction in jQuery objects in compile/link. This also reduces the jqLite objects created in thescope/isolatedScope/data/inheritedDatamethods and simplifiesjqLiteInheritedData. Note that this change overrides the first commit.If interested I can squash all the commits and maybe add more tests for the jqLite changes.