This repository was archived by the owner on Apr 12, 2024. It is now read-only.
perf($compile, jqLite): reduce creation of unnecessary jquery objects #7963
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the creation of many duplicate or unnecessary jQuery objects in the compile/link phases as well as in some jqLite methods.
Most of the changes are pretty minor and safe (as far as myself and the tests can tell).
The only bigger change is exposing
jqLiteData/jqLiteRemoveData
asjqLite.data/removeData
to match the jQuery equivalent (https://api.jquery.com/jquery.data/). This allows getting/setting data without creating the jQuery wrapper object and allows for the biggest reduction in jQuery objects in compile/link. This also reduces the jqLite objects created in thescope/isolatedScope/data/inheritedData
methods and simplifiesjqLiteInheritedData
. Note that this change overrides the first commit.If interested I can squash all the commits and maybe add more tests for the jqLite changes.