Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix($location): right button click in firefox #8013

Closed
wants to merge 1 commit into from
Closed

fix($location): right button click in firefox #8013

wants to merge 1 commit into from

Conversation

krom-xr
Copy link
Contributor

@krom-xr krom-xr commented Jun 28, 2014

When user click right mouse button on links in firefox, browser goes to
link. See http://jsfiddle.net/kromxr/76fKM/12/

Closes #7984

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#8013)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@krom-xr krom-xr added cla: no and removed cla: yes labels Jun 28, 2014
@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@krom-xr krom-xr added cla: yes and removed cla: no labels Jun 28, 2014
@Narretz Narretz added this to the Backlog milestone Jul 11, 2014
@Narretz
Copy link
Contributor

Narretz commented Jul 11, 2014

@rodyhaddad I saw you had your own fix for this (rodyhaddad@03fa204), would you mind taking a look at the PR?

@krom-xr
Copy link
Contributor Author

krom-xr commented Jul 11, 2014

Ok

@btford btford removed the gh: PR label Aug 20, 2014
@chrisnicola
Copy link
Contributor

Users not able to right click links is pretty severe. Anything still holding this up? I'm going to have to patch my local environment for now but I'm surprised this is taking so long.

@jeffbcross jeffbcross force-pushed the master branch 3 times, most recently from 8292c21 to 7b9fddf Compare October 9, 2014 20:43
@Narretz Narretz modified the milestones: 1.3.0, Backlog Oct 10, 2014
@vincentjames501
Copy link

+1. Please merge!

@vincentjames501
Copy link

I should note for those interested, this resolved my issues:

https://groups.google.com/forum/#!msg/angular/LAk9oZqRx24/sWKr5jFJQ1AJ

@bukharin
Copy link

bukharin commented Dec 9, 2014

Please merge!

@pkozlowski-opensource pkozlowski-opensource modified the milestones: 1.3.8, 1.3.x, 1.3.7 Dec 9, 2014
@krom-xr
fix($location): right button click in firefox
9008d8d 
When user click right mouse button on links in firefox, browser goes to
link. See http://jsfiddle.net/kromxr/76fKM/12/

Closes angular#7984

Conflicts:
	src/ng/location.js
	test/ng/locationSpec.js
@krom-xr krom-xr force-pushed the firefox-right-button-fix branch from f56fc58 to 9008d8d Compare December 11, 2014 12:38
@googlebot
Copy link

CLAs look good, thanks!

@petebacondarwin petebacondarwin modified the milestones: 1.3.7, 1.3.8 Dec 15, 2014
@btford btford modified the milestones: 1.3.8, 1.3.9 Dec 19, 2014
@BrianMcBrayer
Copy link

Any chance this could get pulled in sooner rather than later?

@lgalfaso
Copy link
Contributor

landed as aa798f1

@lgalfaso lgalfaso closed this Jan 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
browser: Firefox cla: yes component: $location type: bug
Projects
None yet
Milestone
1.4.0-beta.0
Development

Successfully merging this pull request may close these issues.

the link with the right mouse button in firefox