This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat(input): support constant expressions for ngTrueValue/ngFalseValue #8041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
ngTrueValue and ngFalseValue now support parsed expressions which the parser determines to be constant values.
BREAKING CHANGE:
Previously, these attributes would always be treated as strings. However, they are now parsed as
expressions, and will throw if an expression is non-constant.
To convert non-constant strings into constant expressions, simply wrap them in an extra pair of quotes, like so:
<input type="checkbox" ng-model="..." ng-true-value="'truthyValue'">
|
LGTM |
|
lgtm |
ckknight
pushed a commit
to ckknight/angular.js
that referenced
this pull request
Jul 16, 2014
ngTrueValue and ngFalseValue now support parsed expressions which the parser determines to be constant values.
BREAKING CHANGE:
Previously, these attributes would always be treated as strings. However, they are now parsed as
expressions, and will throw if an expression is non-constant.
To convert non-constant strings into constant expressions, simply wrap them in an extra pair of quotes, like so:
<input type="checkbox" ng-model="..." ng-true-value="'truthyValue'">
Closes angular#8041
Closes angular#5346
Closes angular#1199
christianvuerings
added a commit
to christianvuerings/calcentral
that referenced
this pull request
Oct 15, 2014
https://jira.ets.berkeley.edu/jira/browse/CLC-4379 http://angularjs.blogspot.com/2014/10/angularjs-130-superluminal-nudge.html https://docs.angularjs.org/guide/migration#migrating-from-1-2-to-1-3 QA Focus: * Datepicker * Tasks - setting completed /uncompleted angular/angular.js#8041 * Watch the developer console in the browsers for new errors / warnings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ngTrueValue and ngFalseValue now support parsed expressions which the parser
determines to be constant values.
BREAKING CHANGE:
Previously, these attributes would always be treated as strings. However, they
are now parsed as expressions, and will throw if an expression is
non-constant.
To convert non-constant strings into constant expressions, simply wrap them in
an extra pair of quotes, like so:
(This is an alternative solution to #5346, /CC @IgorMinar PTAL)