fix(input): trigger modelValue update on viewValue property changes #8047
Conversation
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
Here is a Plunker with the angular.js file patched accordingly to demonstrate that this works. |
If the $viewValue is an object then we should trigger a model update if properties on that object change. Previously, we were only checking for change of object identity. Closes angular#7965
|
Since this fix relies upon |
| return; | ||
| } | ||
| ctrl.$$lastCommittedViewValue = viewValue; | ||
| ctrl.$$lastCommittedViewValue = copy(viewValue); |
There was a problem hiding this comment.
I think the copy should be done as early as possible (in $setViewValue) and not here, otherwise updates to the object that was passed in might effect ctrl.$viewValue, ctrl.$modelValue and the scope bound to it.
|
Closing as not the right solution. See the original issue #7965 for more information |
If the $viewValue is an object then we should trigger a model update
if properties on that object change.
Previously, we were only checking for change of object identity.
Closes #7965