Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

chore(e2e): update protractor to 1.0.0-rc4 #8111

Closed
wants to merge 1 commit into from

Conversation

juliemr
Copy link
Member

@juliemr juliemr commented Jul 8, 2014

This change contains a stability improvement to use data URLs instead of
about:blank for resetting the URL.

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#8111)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@juliemr
Copy link
Member Author

juliemr commented Jul 8, 2014

Investigating safari errors.

@juliemr
Copy link
Member Author

juliemr commented Jul 8, 2014

SafariDriver doesn't allow executing webdriver commands on the data url: angular/protractor#1049

@juliemr juliemr added cla: yes and removed cla: no labels Jul 8, 2014
This change contains a stability improvement to use data URLs instead of
about:blank for resetting the URL.
@juliemr juliemr changed the title chore(e2e): update protractor to 1.0.0-rc3 chore(e2e): update protractor to 1.0.0-rc4 Jul 8, 2014
@juliemr
Copy link
Member Author

juliemr commented Jul 8, 2014

Everything is now passing and ready to go - https://travis-ci.org/angular/angular.js/builds/29457532

@btford
Copy link
Contributor

btford commented Jul 8, 2014

LGTM

@IgorMinar
Copy link
Contributor

lgtm

@juliemr
Copy link
Member Author

juliemr commented Jul 8, 2014

Thanks! Merged to 1.2.x as 05597c2 and master as 88a3257

@juliemr juliemr closed this Jul 8, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants