Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fixed controller name in markup #8206

Closed
wants to merge 1 commit into from
Closed

fixed controller name in markup #8206

wants to merge 1 commit into from

Conversation

mxab
Copy link
Contributor

@mxab mxab commented Jul 15, 2014

Request Type: docs

How to reproduce:

Component(s): forms

Impact: small

Complexity: small

This issue is related to:

Detailed Description:

The "Binding to form and control state" sample had a wrong controller name which prevents the sample from running

Other Comments:

The "Binding to form and control state" sample had a wrong controller name
@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#8206)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@mxab mxab added cla: no and removed cla: yes labels Jul 15, 2014
@Narretz
Copy link
Contributor

Narretz commented Jul 15, 2014

@petebacondarwin Can you please merge this one, or #8133? There is even another one, but I can't find it now

@petebacondarwin
Copy link
Contributor

Will do. Closing as duplicate of #8133

petebacondarwin pushed a commit that referenced this pull request Jul 15, 2014
petebacondarwin pushed a commit that referenced this pull request Jul 15, 2014
@Narretz
Copy link
Contributor

Narretz commented Jul 15, 2014

... that PR is actually for a different file, with the same problem, my bad

P.S. I blame @btford ! 😈

@Narretz Narretz reopened this Jul 15, 2014
@Narretz Narretz mentioned this pull request Jul 15, 2014
@Narretz Narretz added this to the 1.3.0 milestone Jul 15, 2014
@petebacondarwin
Copy link
Contributor

:-) Will fix tomorrow

@btford
Copy link
Contributor

btford commented Jul 15, 2014

✨ I regret nothing. ✨

ckknight pushed a commit to ckknight/angular.js that referenced this pull request Jul 16, 2014
petebacondarwin pushed a commit that referenced this pull request Jul 16, 2014
The "Binding to form and control state" sample had the wrong controller name

Closes #8206
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants