Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix($location): handle plus character in query strings #8245

Closed
wants to merge 1 commit into from

Conversation

caguillen214
Copy link

Closes #3042

@mary-poppins
Copy link

Cool 🐟

@btford btford added this to the 1.3.0-beta.16 milestone Jul 17, 2014
@btford
Copy link
Contributor

btford commented Jul 17, 2014

This LGTM. @IgorMinar – do you think we should also add tests for parseKeyValue?

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@IgorMinar
Copy link
Contributor

LGTM

we should do a follow up PR for $location.path which should have similar behavior if it doesn't already.

@caguillen214 please sign CLA

@caguillen214
Copy link
Author

Signed the CLA @IgorMinar

@btford
Copy link
Contributor

btford commented Jul 18, 2014

Landed as 3f4ee15.

@btford btford closed this Jul 18, 2014
@jordanms
Copy link

jordanms commented Aug 4, 2015

I faced this problem on 1.3.15 and reading this I upgraded to 1.3.16. The result is that now I have no idea what the URL will contain! Sometimes + is encoded as %20 and sometimes as %2B and this is really random. I also upgraded to 1.4.3 and problem was there, as in 1.3.15. For my case this fix made it even worse.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

+ (Plus) in URL parameter converted to %2B
5 participants