Add EditorConfig file

[treyhunner]

Request Type: feature

How to reproduce:

Component(s):

Impact:

Complexity: small

This issue is related to:

Detailed Description:

Other Comments:

This file acts as a living style guide. With an EditorConfig plugin installed, this file acts as a self-enforcing style guide.

See http://editorconfig.org for more details.

This should reduce problems such as the one in #8277.

Disclaimer: I'm one of the EditorConfig project team members.

[mary-poppins]

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

• Uses the issue template (#8278)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

[mary-poppins]

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

[Narretz]

Hi, I remember this was proposed a while ago, and the question that came up is still relevant: what does this add over complete jshint coverage? And why did you exclude some files from insert_final_newline

[treyhunner]

@Narretz Differences between JSHint and EditorConfig

• JSHint generally stays agnostic about file formatting and has no opinion on final newlines, trailing whitespace, end-of-line, or tabs/spaces. EditorConfig focuses primarily on these issues.
• JSHint lints your JavaScript. EditorConfig ensures that general file formatting issues (the hardest issues to see) don't happen at all
• JSHint only works on JavaScript files. EditorConfig works on any text file

I removed final newline requirement from dropdown-toggle.js and htmlparser.js because (from my understand) those are third-party libraries which may be updated by external versions from time-to-time.

I removed the final newline requirement from src/ngLocale files because all of the 446 files in that directory are missing a final newline. I assume these are generated by a script/program that leaves out the final newline.

[mary-poppins]

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

[caitp]

we use jscs to enforce style rules

[treyhunner]

@caitp jscs is great as an opinionated JavaScript checker but it:

• doesn't work for all file types
• doesn't catch everything (e.g. end-of-line format, final newlines)
• doesn't enforce these rules within your text editor

These two tools go hand-in-hand. jscs is a highly opinionated JS-specific linter and EditorConfig is a file format enforcer (working within your text editor) that works on all text files.

Note that the jscs developers use a .editorconfig file in their repository.

[pkozlowski-opensource]

+1 for merging it. As @treyhunner says it is just a convenience for an editor so it gets "right" formatting without any need to change editor's settings (apart from installing a plugin that supports editorconfig...)

[IgorMinar]

This can only make it easier for people to make changes to the code in a way that we want them to.

we should merge this in.