This repository was archived by the owner on Apr 12, 2024. It is now read-only.
WIP: [[nomerge]] adapt to location changes happening outside of Angular #8405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: IE9 is experiencing full page reload in tests |
|
@jeffbcross it looks like this isn't ready to land, which is too bad --- I'm moving this (#6976) to the next milestone for now (feel free to reassign it if there's too much stuff!) |
|
@caitp do you have any thoughts on the approach? I'd like to address the open issues and complete this soon. |
|
@tbosch want to take a look? |
|
sorry I missed this one, lets see |
| @@ -29,7 +29,8 @@ function Browser(window, document, $log, $sniffer) { | |||
| history = window.history, | |||
| setTimeout = window.setTimeout, | |||
| clearTimeout = window.clearTimeout, | |||
| pendingDeferIds = {}; | |||
| pendingDeferIds = {}, | |||
| urlChangedOutsideAngular = false; | |||
There was a problem hiding this comment.
nit: don't use an identical name for this symbol and the method --- that gets confusing
…de of Angular $browser keeps an internal representation of the browser's url, and although $browser.url() would return the client's real current url, the $location service that was comparing that url with $location's representation had no way of knowing when the url had been changed outside of Angular. This commit makes browser and location a little bit smarter by setting a flag inside of $browser when it detects that a url changed outside of Angular, allowing $location to parse the new url and update its own internal representation of the url (and react appropriately). Fixes angular#6976
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just opening for Travis for now. Still need to determine if this is best approach to problem described in #6976.