Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(jqLite): allow triggerHandler() to accept custom event #8505

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 31 additions & 20 deletions src/jqLite.js
Original file line number Diff line number Diff line change
Expand Up @@ -947,26 +947,37 @@ forEach({

clone: jqLiteClone,

triggerHandler: function(element, eventName, eventData) {
// Copy event handlers in case event handlers array is modified during execution.
var eventFns = (jqLiteExpandoStore(element, 'events') || {})[eventName],
eventFnsCopy = shallowCopy(eventFns || []);

eventData = eventData || [];

var event = [{
preventDefault: function() {
this.defaultPrevented = true;
},
isDefaultPrevented: function() {
return this.defaultPrevented === true;
},
stopPropagation: noop
}];

forEach(eventFnsCopy, function(fn) {
fn.apply(element, event.concat(eventData));
});
triggerHandler: function(element, event, extraParameters) {

var dummyEvent, eventFnsCopy, handlerArgs;
var eventName = event.type || event;
var eventFns = (jqLiteExpandoStore(element, 'events') || {})[eventName];

if (eventFns) {

// Create a dummy event to pass to the handlers
dummyEvent = {
preventDefault: function() { this.defaultPrevented = true; },
isDefaultPrevented: function() { return this.defaultPrevented === true; },
stopPropagation: noop,
type: eventName,
target: element
};

// If a custom event was provided then extend our dummy event with it
if (event.type) {
dummyEvent = extend(dummyEvent, event);
}

// Copy event handlers in case event handlers array is modified during execution.
eventFnsCopy = shallowCopy(eventFns);
handlerArgs = extraParameters ? [dummyEvent].concat(extraParameters) : [dummyEvent];

forEach(eventFnsCopy, function(fn) {
fn.apply(element, handlerArgs);
});

}
}
}, function(fn, name){
/**
Expand Down
22 changes: 21 additions & 1 deletion test/jqLiteSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -1718,9 +1718,11 @@ describe('jqLite', function() {
element.triggerHandler('click');
event = pokeSpy.mostRecentCall.args[0];
expect(event.preventDefault).toBeDefined();
expect(event.target).toEqual(element[0]);
expect(event.type).toEqual('click');
});

it('should pass data as an additional argument', function() {
it('should pass extra parameters as an additional argument', function() {
var element = jqLite('<a>poke</a>'),
pokeSpy = jasmine.createSpy('poke'),
data;
Expand Down Expand Up @@ -1765,6 +1767,24 @@ describe('jqLite', function() {
expect(clickOnceSpy).toHaveBeenCalledOnce();
expect(clickSpy.callCount).toBe(2);
});

it("should accept a custom event instead of eventName", function() {
var element = jqLite('<a>poke</a>'),
pokeSpy = jasmine.createSpy('poke'),
customEvent = {
type: 'click',
someProp: 'someValue'
},
actualEvent;

element.on('click', pokeSpy);
element.triggerHandler(customEvent);
actualEvent = pokeSpy.mostRecentCall.args[0];
expect(actualEvent.preventDefault).toBeDefined();
expect(actualEvent.someProp).toEqual('someValue');
expect(actualEvent.target).toEqual(element[0]);
expect(actualEvent.type).toEqual('click');
});
});


Expand Down