This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix($location): don't rewrite hash-fragment links in same document #8508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked on #8492 (the reverted commits include some tests because of this CL). This only deals with relative links, and not checking if the rewritten path is the same minus the hash fragment. Should do that too. |
…or legacy browsers This reverts commit 49e7c32.
…n html5Mode This reverts commit 3f04770. Conflicts: src/ng/location.js
$location will no longer rewrite hash fragment links in the same document (specified via href="#hash..."). Closes angular#8478
|
the last commit looks good. still need to review #8492 |
RichardLitt
added a commit
to RichardLitt/angular.js
that referenced
this pull request
Aug 18, 2014
As explained in angular#4608, $location injection can cause issues by inserting a / after a hash in the url, if html5mode is not enabled. Possible fix is in angular#8508.
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa
to
fd2d6c0
Compare
|
This seems to have been fixed by 2294880 (or one of the related $location fixes) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$location will no longer rewrite hash fragment links in the same document
(specified via href="#hash...").
Closes #8478