Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix($parse): ternary should give assignment precedence in middle and right expressions #8512

Closed
wants to merge 1 commit into from
Closed

fix($parse): ternary should give assignment precedence in middle and right expressions #8512

wants to merge 1 commit into from

Conversation

petebacondarwin
Copy link
Contributor

Closes #8484

@petebacondarwin petebacondarwin added this to the 1.3.0-beta.18 milestone Aug 6, 2014
@rodyhaddad
Copy link
Contributor

Related #5434 :p

@petebacondarwin
Copy link
Contributor Author

@rodyhaddad - Oh!
@IgorMinar - come on - it's a simple fix that conforms to the principle of least surprise

@lgalfaso lgalfaso mentioned this pull request Aug 6, 2014
Closed
rodyhaddad added a commit that referenced this pull request Aug 11, 2014
@rodyhaddad @petebacondarwin
feat($parse): allow for assignments in ternary operator branches
93b0c2d 
Closes #8512
Closes #8484
CLoses #5434

Conflicts:
	test/ng/parseSpec.js
@IgorMinar
Copy link
Contributor

Just for the record. I gave up arguing about this one :-)
On Aug 11, 2014 9:04 AM, "Rodric Haddad" notifications@github.com wrote:

Closed #8512 #8512 via 2d678f1
2d678f1
.

—
Reply to this email directly or view it on GitHub
#8512 (comment).

@theurere theurere mentioned this pull request Aug 26, 2014
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
branch: 1.2.x cla: yes component: $parse frequency: low needs: review type: bug
Projects
None yet
Milestone
1.3.0-beta.19
Development

Successfully merging this pull request may close these issues.

Ternary operator $parse error
3 participants
@petebacondarwin @rodyhaddad @IgorMinar