This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($animate): ensure guarded animations consider AJAX requests upon bootstrap #8540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } else if(val === 0) { | ||
| // ...when the template has been downloaded we digest twice again until the | ||
| // animations are set to enabled (since enter, leave and move require a follow-up). |
There was a problem hiding this comment.
it would be good to see more inline comments in the ngAnimate code, +1 for adding some.
| * No they are not. When an application is bootstrapped Angular will disable animations from running to avoid | ||
| * a frenzy of animations from being triggered as soon as the browser has rendered the screen. For this to work, | ||
| * Angular will wait for two digest cycles until enabling animations. From there on, any animation-triggering | ||
| * layout changes in the application will be handled naturally. |
There was a problem hiding this comment.
what does "naturally" mean here? can you be more specific?
matsko
force-pushed
the
pr_8275
branch
3 times, most recently
from
923804d to
3d2f571
Compare
This handy service is designed to download and cache template contents and to throw an error when a template request fails. BREAKING CHANGE Angular will now throw a $compile minErr each a template fails to download for ngView, directives and ngMessage template requests. This changes the former behavior of silently ignoring failed HTTP requests--or when the template itself is empty. Please ensure that all directive, ngView and ngMessage code now properly addresses this scenario. NgInclude is uneffected from this change.
…bootstrap Prior to this fix when an Angular application is bootstrapped it would only place an animation guard to prevent animations from running when the application starts for the first two digest cycles. However, if any controllers or directives, that are executed upon boostrap, trigger any remote code to be downloaded (via $http) then the guard does not put that into consideration. This fix now properly addresses that circumstance and removes the guard once all outbound HTTP requests are complete when an Angular application is bootstrapped. Closes angular#8275 Closes angular#5262
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this fix when an Angular application is bootstrapped it would only
place an animation guard to prevent animations from running when the application
starts for the first two digest cycles. However, if any controllers or directives,
that are executed upon boostrap, trigger any remote code to be downloaded (via $http)
then the guard does not put that into consideration. This fix now properly addresses
that circumstance and removes the guard once all outbound HTTP requests are complete
when an Angular application is bootstrapped.
Closes #8275
Closes #5262