This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(): allow spaces around dots for identifiers #8550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is definitively a corner case and I'm not sure we want to support this but was looking into parser's code and saw #4613 so get a quick stab at it. For me we can just decide not to merge this one and close #4613 as won't fix. At the same time looks like someone bumped into this scenario and cared enough to open an issue... Anyway, it is here.... |
| @@ -263,15 +263,17 @@ Lexer.prototype = { | |||
| var ident = ''; | |||
| var start = this.index; | |||
|
|
|||
| var lastDot, peekIndex, methodName, ch; | |||
| var lastDot, justSeenADot, peekIndex, methodName, ch; | |||
There was a problem hiding this comment.
Totally minor thing, but grammatically this would be: justSawADot
pkozlowski-opensource
added a commit
to pkozlowski-opensource/angular.js
that referenced
this pull request
Aug 10, 2014
|
Thnx @lord2800 for the heads up, updated. |
| ident += ch; | ||
| } else { | ||
| break; | ||
| if (!(this.isWhitespace(ch) && justSawADot)) { |
There was a problem hiding this comment.
else if (!(this.isWhitespace(ch) && justSawADot)) {
break;
}There was a problem hiding this comment.
Oh, right. Changing, thnx!
|
looks okay to me. I'm not sure if we want to support that, but I don't see an issue with being a tiny bit more flexible there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4613