This repository was archived by the owner on Apr 12, 2024. It is now read-only.
DUPE of 8358 (1 commit added) #8601
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a $route#update method for changing the current route parameters without having to build a URL and call $location#path. Useful for apps with a structure involving programmatically moving between pages on the current route, but with different :param values.
This ensures that parameters are matched to the correct value when being updated.
Adds a check to ensure the $location.path() changes to an expected URL when the route changes.
Change the name of the method to make clearer its purpose.
Better to use angular methods than my clunky code.
I accidentally added the updateParams tests inside of the tests for `reloadOnSearch` - This commit extracts them to their own describe block.
Properties in the object passed to $route.updateParams() will be added to the location as queryParams if not contained within the route's path definition.
|
Merged: 77a1acc |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull requesting for Travis with new commit + rebase