This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Fixed documentation for controller ^ search
#8622
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 'current element' to 'its parents'.
|
@Izhaki thnx, this is a good change. Could you please amend the commit message to something like |
|
I'm afraid I've done this directly form the site 'Improve the docs' link, rather than via my local repro. I'm not even sure I can do it myself... but if possible, please let me know how. |
|
@Izhaki you would have to clone your forked repo, amend the commit message and force-push it. But don't worry to much about this, we can amend the commit message while merging. It is just having commit messages following our conventions saves us a bit of time. |
|
lgtm |
caitp
pushed a commit
that referenced
this pull request
Aug 19, 2014
…tation `^` searches the element and its parents, not exclusively the element's parents. This confuses a lot of people :( Closes #8622
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 'current element' to 'its parents'.