docs: update module.ngdoc Hello World example #8673
Conversation
Helpful for people new to Angular to see the ng-app declaration in context with the expression example. This will help illustrate the "Important thing to notice" point which follows: "The reference to myApp module in <html ng-app="myApp">. This is what bootstraps the app using your module."
| @@ -28,9 +28,11 @@ I'm in a hurry. How do I get a Hello World module working? | |||
|
|
|||
| <example module='myApp'> | |||
There was a problem hiding this comment.
Need to add ng-app-included to the <example> tag for this to work
There was a problem hiding this comment.
sorry, I must be doing something wrong. I updated the commit as suggested but TravisCI is failing..getting this error: Error: No element found using locator: by.binding("{{ 'World' | greet }}")
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
all set, CLA now signed |
fixed indentation, replaced <html> w/ <div>, and added "ng-app-included" to <example>
|
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
definitelynotsoftware
changed the title
|
yeah we probably need to update the E2E test too, i'll help you with that in a sec |
|
So, unfortunately we have an issue where the e2e tests are always going to try to use the "body" tag as the root element, and when we have So, we can't really land this unless we get rid of those tests. Personally I don't think those are adding much so it might be good to get rid of some, but we'll see what other people think I guess |
/cc @petebacondarwin / @juliemr please review :> Blocks angular#8673
/cc @petebacondarwin / @juliemr please review :> Blocks #8673 Closes #8677
/cc @petebacondarwin / @juliemr please review :> Blocks #8673 Closes #8677
| @@ -26,11 +26,13 @@ should be bootstrapped. There are several advantages to this approach: | |||
|
|
|||
| I'm in a hurry. How do I get a Hello World module working? | |||
|
|
|||
| <example module='myApp'> | |||
| <example ng-app-included module='myApp'> | |||
There was a problem hiding this comment.
I've landed a fix for the e2e bugs you were getting. So can I get you to change this very slightly, to make it ng-app-included="true" instead? We need a value, otherwise the template engine doesn't know that there's a value for it.
Also fix the indentation a bit and see if the tests are green, we should be okay to merge it after that
There was a problem hiding this comment.
great to hear. OK I'll have this ready in a sec...
|
e2e tests are coming back green - are we good to go? |
|
yeah works for me |
Helpful for people new to Angular to see the ng-app declaration in context with the expression example. This will help illustrate the "Important thing to notice" point which follows: "The reference to myApp module in <html ng-app="myApp">. This is what bootstraps the app using your module." Closes #8673
Helpful for people new to Angular to see the ng-app declaration in context with the expression example. This will help illustrate the "Important thing to notice" point which follows: "The reference to myApp module in . This is what bootstraps the app using your module."