This repository was archived by the owner on Apr 12, 2024. It is now read-only.
refactor($q): make $q Promises A+ v1.1 compilant #8708
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Promises A+ 1.1 spec introduces new constraints that would cause $q to fail, particularly specs 2.3.1 and 2.3.3. Newly satisfied requirements: * "then" functions that return the same fulfilled/rejected promise will fail with a TypeError * Support for edge cases where "then" is a value other than function Full 1.1 spec: https://github.com/promises-aplus/promises-spec/tree/1.1.0 This commit also modifies the adapter to use "resolve" method instead of "fulfill"
| 'finallyCC()->IGNORED', | ||
| 'successBB(RESOLVED_VAL)->bb', |
There was a problem hiding this comment.
I still don't really understand why adding support for those constraints breaks this test, that just seems weird
There was a problem hiding this comment.
@lgalfaso any thoughts?
|
still generally LGTM but I would really like to properly understand why we break that test some time |
|
@caitp good to merge? |
|
yeah I think so |
|
Landed 1339c11 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Promises A+ 1.1 spec introduces new constraints that would cause $q to fail,
particularly specs 2.3.1 and 2.3.3.
Newly satisfied requirements:
will fail with a TypeError
Full 1.1 spec: https://github.com/promises-aplus/promises-spec/tree/1.1.0
This commit also modifies the adapter to use "resolve" method instead of "fulfill"
(PR replaces #5976)