This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngModel): make async validators play nicely with $parsers #8861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when an async validator resolves, we decrease the `pendingCount` only if the `$viewValue` hasn't changed in the mean time. before this commit the view value after resolve was compared with the model value before resolve instead of the view value before resolve. this caused it never to resolve when those two are different (when `$parsers` are defined)
|
This was fixed by the latest commits in master. I added a variant of the tests to the test suite of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when an async validator resolves, we decrease the
pendingCountonly if the$viewValuehasn't changed in the mean time. before this commit the view value after resolve was compared with the model value before resolve instead of the view value before resolve. this caused it never to resolve when those two are different (when$parsersare defined)