This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngModel): do not reset bound date objects #8912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tbosch Can you please review this? |
| @@ -1068,7 +1095,7 @@ function createDateInputType(type, regexp, parseDate, format) { | |||
| ctrl.$parsers.push(function(value) { | |||
| if (ctrl.$isEmpty(value)) return null; | |||
| if (regexp.test(value)) { | |||
| var parsedDate = parseDate(value); | |||
| var parsedDate = parseDate(value, ctrl.$modelValue, timezone); | |||
There was a problem hiding this comment.
Only pass in value and ctrl.$modelValue.
If timezone===UTC then clone the date in ctrl.$modelValue and adjust the timezone here, so that you can use the normal getDay(), ... in the date and week parser.
There was a problem hiding this comment.
done; how's it look now?
btford
force-pushed
the
fix-input-date
branch
2 times, most recently
from
9e55c46 to
b48fcd7
Compare
| compileInput('<input type="month" ng-model="value" ng-model-options="{timezone: \'UTC\'}" />'); | ||
|
|
||
| scope.$apply(function() { | ||
| scope.value = new Date(Date.UTC(2013, 7, 1, 1, 0, 0)); |
btford
force-pushed
the
fix-input-date
branch
from
b48fcd7 to
095ff89
Compare
btford
force-pushed
the
fix-input-date
branch
from
095ff89 to
b98313f
Compare
|
LGTM |
|
Landed as 1a1ef62. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6666