Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

style(ngLocale): change es-us lcoale currency format #8965

Closed
wants to merge 1 commit into from
Closed

style(ngLocale): change es-us lcoale currency format #8965

wants to merge 1 commit into from

Conversation

dfalgout
Copy link

@dfalgout dfalgout commented Sep 6, 2014

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@dfalgout
Copy link
Author

dfalgout commented Sep 6, 2014

cla is signed and submitted

change es-us locale currency format, before: $1.234,56 - after: $1,234.56

closes #8931
@dfalgout dfalgout changed the title Fixed locale es_us currency format style(ngLocale): change es-us lcoale currency format Sep 6, 2014
@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@lgalfaso
Copy link
Contributor

lgalfaso commented Sep 6, 2014

Thanks for the PR, but this file is auto-generated from Google Closure Library. If you want to fix this, then the way is the following:
If the Closure Library has this wrong, then open an issue there and then ask here for the locale information to be regenerated
If the Closure Library has this right, then
If regenerating the locales fixes this, then send a PD with this
If regenerating the locales does not fix this, then check why this is the case and send a PR with a fix

I am closing this now as this PR is not following the guidelines

@lgalfaso lgalfaso closed this Sep 6, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Currency & Number Format for es-us Locale
3 participants