This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngInclude): correctly add svg-namespaced template content [[squashed]] #8997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now possible for ngInclude to correctly load SVG content in non-blink browsers, which do not sort out the namespace when parsing HTML. Closes angular#7538
caitp
changed the title
caitp
changed the title
caitp
changed the title
| @@ -267,6 +267,18 @@ var ngIncludeFillContentDirective = ['$compile', | |||
| priority: -400, | |||
| require: 'ngInclude', | |||
| link: function(scope, $element, $attr, ctrl) { | |||
| if (/SVG/.test($element[0].toString())) { | |||
There was a problem hiding this comment.
Is this always going to be uppercase?
There was a problem hiding this comment.
Oh right it will be the class name not the node name. Cool
|
LGTM |
|
Thanks Pete |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible for ngInclude to correctly load SVG content in non-blink
browsers, which do not sort out the namespace when parsing HTML.
Closes #7538
Closes #8981