This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(input): remove $$invalidModelValue and always set $modelValue to the... #9002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the parser result BREAKING CHANGE: $modelValue is now always set to the result of $parsers, even if validation fails. Setting it to undefined was a remnant of the old parsers-for-validation behavior. The new behavior is more consistent. If you relied on $modelValue becoming undefined when invalid, e.g. in a $watch, you must now use the $valid property of ngModelController.
|
@shahata Can you have a look? Unfortunately, @tbosch has decided that always setting $modelValue to parser result is a bad idea (#8357 (comment)) |
|
Forget my previous comment... @shahata I would like to keep the previous behavior of Please post if there is a use case where this does not work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... parser result
BREAKING CHANGE:
$modelValue is now always set to the result of $parsers, even if
validation fails. Setting it to undefined was a remnant of the old parsers-for-validation behavior. The new behavior is more consistent: if you modify the validity state of the control, the $modelValue itself is not changed.
If you relied on $modelValue becoming undefined when invalid, e.g. in
a $watch, you must now use the $valid property of ngModelController.