This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($compile): remove comment nodes from templates before asserting single root node #9215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So if the template is a single comment that makes reference to a directive, then it would stop working? |
|
yeah pretty much --- in practice nobody actually does that though, Igor has said in the past that supporting comment directives at all was probably a mistake |
|
If it makes you feel better, we could avoid changing the object unless there is more than one node |
…ingle root node The compiler will no longer throw if a directive template contains comment nodes in addition to a single root node. The comment nodes will be removed before processing. Closes angular#9212
|
now avoids the breaking change =) |
Agree LGTM |
|
LGTM |
| @@ -1951,7 +1951,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) { | |||
| if (jqLiteIsTextNode(content)) { | |||
| $template = []; | |||
| } else { | |||
| $template = jqLite(wrapTemplate(templateNamespace, trim(content))); | |||
| $template = removeComments(jqLite(wrapTemplate(templateNamespace, trim(content)))); | |||
There was a problem hiding this comment.
how many more function calls can we make in this line of code? :)
|
otherwise this looks good to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler will no longer throw if a directive template contains comment
nodes in addition to a single root node.
The comment nodes will be removed before processing.
Closes #9212