This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(inputs): ignoring input events in IE caused by placeholder changes o... #9264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s or focus/blur on inputs with placeholders
|
Open the PR against the master branch, it will be cherry-picked into v1.2.x if it lands |
|
Bah, sorry, just close this one then? |
|
yeah |
|
K, will reopen in a minute... |
|
Created #9265. Inputs and validation sure have changed in 1.3, but the fix seems to be the same. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...r focus/blur on inputs with placeholders
This is my attempt at fixing #8242 as well as the extra placeholder issues with focus/blur. I'm assuming I'm missing a weird test case that still breaks somewhere, but I still think this is an improvement (it definitely is for my use cases). This PR is for 1.2.x because this was a 1.2 regression.