This repository was archived by the owner on Apr 12, 2024. It is now read-only.
test($compile): add test for alternative syntax to get controllers from ancestors #9390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om ancestors Because the regex that tests the `require` value will match more than just `^^?`, it is important to test other common ways to specify a controller requirement to ensure that a breaking change isn't introduced inadvertently. This adds a test for `?^^`. Closes #9389
|
Here's the PR for adding that test @caitp :-) |
|
Thanks, it looks good to me. It might also be good to add another one for the single "^" following the ?, but I don't think it should block landing this |
|
Good idea, I'll create another PR for that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the regex that tests the
requirevalue will match more than just^^?,it is important to test other common ways to specify a controller requirement
to ensure that a breaking change isn't introduced inadvertently. This adds a test
for
?^^.Closes #9389