This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(orderBy): sort by identity if no predicate is given #9403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petebacondarwin
force-pushed
the
sortOrder-fix
branch
from
eee537f to
ac5d99d
Compare
| @@ -125,6 +128,12 @@ function orderByFilter($parse){ | |||
| descending = predicate.charAt(0) == '-'; | |||
| predicate = predicate.substring(1); | |||
| } | |||
| if ( predicate === '' ) { | |||
|
lgtm |
| @@ -125,6 +128,12 @@ function orderByFilter($parse){ | |||
| descending = predicate.charAt(0) == '-'; | |||
There was a problem hiding this comment.
Any particular reason why == instead of === ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation handles all the various corner cases more consistently.
Closes #5847
Closes #4579