This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat(ngRoute): allow cancelling $route updates via $routeChangeEvent #9407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, one could perform this feat by listening to both $locationChangeStart as well as $routeChangeStart, and being careful to update the route correctly. Now, it's possible to simply preventDefault() on the $beforeRouteChange event in order to prevent location and route from being updated. While this does not cancel $routeChangeStart, it does ensure that the correct location is restored, and provides the same information as $routeChangeStart. Closes angular#5855 Closes angular#5714 Closes angular#5581
Previously, this was asserting that $beforeRouteChange was never called. Prior to the preceeding commit, $beforeRouteChange didn't exist --- however it is called during $locationChangeStart. It looks like this test should be asserting that $routeChangeStart is never fired.
|
@IgorMinar updated based on discussion, LGTY? it fixes a broken assertion in a test too, which is nice |
caitp
added
component: ngRoute
type: feature
frequency: moderate
severity: broken expected use
frequency: low
and removed
frequency: moderate
labels
jeffbcross
force-pushed
the
master
branch
3 times, most recently
from
8292c21 to
7b9fddf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, one could perform this feat by listening to both
$locationChangeStart as well as $routeChangeStart, and being careful to
update the route correctly. Now, it's possible to simply preventDefault()
on the
$beforeRouteChange event in order to prevent location and route from being
updated.
While this does not cancel $routeChangeStart, it does ensure that the
correct location is restored, and provides the same information as
$routeChangeStart.
Closes #5855
Closes #5714
Closes #5581