This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($browser): Cache location.href only during page reload phase
#9455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IgorMinar Here is the change to The initial solution for #9235 was wrong as the added tests for #6976 show. Will add another commit tomorrow to move this code into |
test/ng/browserSpecs.js
Outdated
There was a problem hiding this comment.
can you mention why we digest many times?
Adds caching for url changes while a reload is happening, as browsers do not allow to read out the new location the browser is navigating to. Removes unnecessary caching from $browser, as IE7-IE9 all have the new hash value in `location.href` after changing it. There was a wrong assumption in the previous version of this code introduced by dca2317 and d707114. Adds more tests for angular#6976 Fixes angular#9235
tbosch
added a commit
to tbosch/angular.js
that referenced
this pull request
Oct 7, 2014
Adds caching for url changes while a reload is happening, as browsers do not allow to read out the new location the browser is navigating to. Removes unnecessary caching from $browser, as IE7-IE9 all have the new hash value in `location.href` after changing it. There was a wrong assumption in the previous version of this code introduced by dca2317 and d707114. Adds more tests for angular#6976 Fixes angular#9235 Closes angular#9455
bullgare
pushed a commit
to bullgare/angular.js
that referenced
this pull request
Oct 9, 2014
Adds caching for url changes while a reload is happening, as browsers do not allow to read out the new location the browser is navigating to. Removes unnecessary caching from $browser, as IE7-IE9 all have the new hash value in `location.href` after changing it. There was a wrong assumption in the previous version of this code introduced by dca2317 and d707114. Adds more tests for angular#6976 Fixes angular#9235 Closes angular#9455
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds caching for url changes after a reload happens
Removes unnecessary caching from $browser, as IE-IE9 all allow to change
location.hrefsynchronously, i.e. after changing it (via property write or `location.replace) it can be read out immediately with the up to date value.There was a wrong assumption in the previous version of this code
introduced by dca2317 and d707114.
Adds more tests for #6976
Fixes #9235