fix($http): don't run transformData on HEAD methods #9528
Conversation
7b6c1d0 indadvertantly created this issue by using Content-Type to determine when to run fromJson. Because HEAD methods do not contain a body but are supposed to return the Content-Type header that would have been returned if it was a GET this functionality fails.
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
7b6c1d0 created this issue by using `Content-Type` to determine when to run `fromJson`. Because `HEAD` methods do not contain a body but are supposed to return the `Content-Type` header that would have been returned if it was a `GET` this functionality fails. Closes angular#9528
|
Nice, thanks! |
|
Note: Created a new PR to simplify you change a little but... |
|
I definitely filled out the cla, maybe I missed a confirmation dialog or similar, will do it again now. |
|
ok cla was filled out again. let me know if you don't get it. |
7b6c1d0 created this issue by using `Content-Type` to determine when to run `fromJson`. Because `HEAD` methods do not contain a body but are supposed to return the `Content-Type` header that would have been returned if it was a `GET` this functionality fails. Closes angular#9528
|
the CLA verification failed because the commit signature contains different email address as the one used for CLA. You can see the email used in the commit here: https://github.com/angular/angular.js/pull/9528.patch |
|
You're right, I accidentally used my corporate email with that commit. I'll create a new pull request with the proper email address. |
7b6c1d0 indadvertantly created this issue by using Content-Type to
determine when to run fromJson. Because HEAD methods do not contain
a body but are supposed to return the Content-Type header that would
have been returned if it was a GET this created a bug in HEAD requests.