This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(select): add basic track by and select as support #9533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: add tests for multiple select, and object data source |
| scope.obj = {'10': {score: 10, label: 'ten'}, '20': {score: 20, label: 'twenty'}}; | ||
| }); | ||
|
|
||
|
|
||
| it('should throw a helpful minerr', function() { | ||
| expect(function() { | ||
| it('should bind to scope value through experession while tracking/identifying objects', function() { |
There was a problem hiding this comment.
"It should use the "value" variable to represent items in the array as well as for the selected values in track by expression"
Instead of throwing an error when using "track by" and "select as" expressions, ngOptions will assume that the track by expression is valid, and will use it to compare values. Closes angular#6564
jeffbcross
force-pushed
the
issue-6564
branch
from
46e10e1 to
526498a
Compare
| @@ -3,6 +3,9 @@ | |||
| @fullName Comprehension expression cannot contain both `select as` and `track by` expressions. | |||
| @description | |||
|
|
|||
| NOTE: This error was introduced in 1.3.0-rc.5, and was removed for 1.3.0-rc.6 in order to | |||
| accommodate existing apps that write complex enough `track by` expressions to work with `select as`. | |||
There was a problem hiding this comment.
"to not break existing apps" and remove the "complex enough" part onward.
|
Landed addfff3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of throwing an error when using "track by" and "select as" expressions,
ngOptions will assume that the track by expression is valid, and will use it to
compare values.