This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(filter): format timezone correctly #9534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes timezone formatting in case UTC timezone is used Closes #9359
| @@ -471,7 +476,7 @@ function dateFilter($locale) { | |||
| } | |||
| forEach(parts, function(value){ | |||
| fn = DATE_FORMATS[value]; | |||
| text += fn ? fn(date, $locale.DATETIME_FORMATS) | |||
| text += fn ? fn(date, $locale.DATETIME_FORMATS, timezone) | |||
There was a problem hiding this comment.
this seems really hackish to me, any suggestions?
|
I added another commit here for supporting conversion to timezone other than UTC because it bothered me... Is this something we want? |
| var offset = date.getTimezoneOffset(); | ||
| if (timezone) { | ||
| var zone = Date.parse('1970-01-01 00:00:00 ' + timezone) / 60000; | ||
| if (zone === zone) { |
There was a problem hiding this comment.
Do you prefer we throw on invalid timezone?
petebacondarwin
force-pushed
the
master
branch
from
4dd5a20 to
998c61c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes timezone formatting in case UTC timezone is used
Closes #9359