This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($http): don't run transformData on HEAD methods #9555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7b6c1d0 indadvertantly created this issue by using Content-Type to determine when to run fromJson. Because HEAD methods do not contain a body but are supposed to return the Content-Type header that would have been returned if it was a GET this created a bug in HEAD requests.
|
@tbosch / @IgorMinar you can close this one if you're confident the other PR will land first |
|
+1 for me for the 204 no content version, seems like that will cover a few more scenarios. I'll leave this open for now, but feel free to close it if you choose to go the other way. |
|
Closing this as we will have a more general handling... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7b6c1d0 indadvertantly created this issue by using Content-Type to
determine when to run fromJson. Because HEAD methods do not contain
a body but are supposed to return the Content-Type header that would
have been returned if it was a GET this created a bug in HEAD requests.